Update all gpg --recv-keys invocations with explicit "did it download" checks#2252
Merged
PeterDaveHello merged 1 commit intonodejs:mainfrom Jul 7, 2025
Merged
Conversation
…ad" checks This solves for the case of `gpg --recv-keys` receiving enough valid data that it doesn't return a non-zero exit code, but that it also doesn't import a key by explicitly checking afterwards that it did import the key we asked for (so that the fallback to keyserver.ubuntu.com actually happens appropriately for keys whose UID are no longer validated on keys.openpgp.org).
Contributor
Author
|
(all those "linting" annotations are especially annoying to see here, especially given I'm the author of moby/buildkit#5130 😅) |
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
Thanks for proposing this remedy! I've duplicated it to PR cypress-io/cypress-docker-images#1380 which builds Docker images for Cypress based on selectable versions of Node.js, browser versions, etc. for website testing. |
PeterDaveHello
approved these changes
Jul 6, 2025
|
Created PR on the official-images repo (docker-library/official-images#19405). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub. |
12 tasks
chorrell
added a commit
to chorrell/docker-image-testing-example
that referenced
this pull request
Aug 12, 2025
chorrell
added a commit
to chorrell/docker-image-testing-example
that referenced
this pull request
Aug 12, 2025
* Update how keys are fetched See: nodejs/docker-node#2252 * Fix Dockerfile linting issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves for the case of
gpg --recv-keysreceiving enough valid data that it doesn't return a non-zero exit code, but that it also doesn't import a key by explicitly checking afterwards that it did import the key we asked for (so that the fallback to keyserver.ubuntu.com actually happens appropriately for keys whose UID are no longer validated on keys.openpgp.org).See also: